Re: [PATCH 10/43] stop_machine: reimplement without using workqueue

[Tejun Heo]

Hello,

On 03/02/2010 01:50 AM, Oleg Nesterov wrote:
>> Oh, I see.  I was thinking get/put_online_cpus() block is exclusive
>> against cpu_maps_update_begin/done() instead of
>> cpu_hotplug_begin/done().  Will update and add comments.
> 
> Agreed, a little comment can help.
> 
> But, just in case, I forgot to repeat this case is not possible anyway.
> _cpu_down() ensures idle_cpu(cpu) == T after __stop_machine(), this means
> that this SCHED_FIFO thread we are going to kthread_stop() later can't
> be active.

Yeah, sure, that was what I was gonna write as comment.  :-)

Thanks for reviewing and see you tomorrow.  It's getting pretty late
(or early) here.  Bye.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/