Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree

[Geert Uytterhoeven]

On Mon, Mar 1, 2010 at 10:42, Frans Pop <elendil@xxxxxxxxx> wrote:
> Paul E. McKenney wrote:
>> This patch appends the SHA1 hash of the current git tree to the
>> kernel version line, or "[Not git tree]" if run from a non-git tree.
>> Uses "git log" to print the hash.
>
> Nice idea.
>
> However, I gave it a try and got:
> # Linux kernel version: 2.6.34-rc0 [Not git tree]
>
> Even though I *am* building from a git tree. It does not seem to work when
> building with KBUILD_OUTPUT set or when using 'O='.
>
> IMO that makes the practical value of the patch very limited. I'm afraid
> because of this it will increase confusion rather than add information.

scripts/setlocalversion handles this case correctly, so you may want to
look there...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/