Re: [GIT PULL] notification: including fanotify

[Stephen Rothwell]

Hi Linus,

On Sat, 27 Feb 2010 13:33:21 -0800 (PST) Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, 27 Feb 2010, Linus Torvalds wrote:
> >
> >  (b) the compile has obviously never been tested with any modern gcc 
> >      version. I get tons of warnings after the pull, like
> 
> In fact, this seems to be due to a commit that explicitly says:
> 
> 				I do not add -Wpointer-sign to the fsnotify
>     code as there are still issues with kstrdup and strlen which would pop
>     out needless warnings.
> 
> but then the patch actually has
> 
> 	--- a/fs/notify/Makefile
> 	+++ b/fs/notify/Makefile
> 	@@ -1,3 +1,5 @@
> 	+EXTRA_CFLAGS   += -Wpointer-sign
> 	+
> 
> WTF? Which part of this was tested AT ALL? Clearly there was not even a 
> compile test going on.

You also forgot to mention that this whole tree has been rebased since
(my) Friday and the version of the above commit in linux-next does not
have that hunk.

As that commit does say, these warnings first came to light when the xfs
tree added that flag to its build.  It was removed again after a couple of
days because it generates quite a few warnings (as you have seen).  It
appears that thee needs to be more cleanup before it is enabled again.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature