Re: [PATCH v2 -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init()

From: David Howells
Date: Fri Feb 26 2010 - 15:43:06 EST


Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> +static inline int
> +call_usermodehelper_keys(char *path, char **argv, char **envp,
> + struct key *session_keyring, enum umh_wait wait)

You should get rid of the inline there. I think it's okay otherwise.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/