Re: [PATCH 1/8] p9auth: set fsuid

From: Greg KH
Date: Thu Feb 25 2010 - 19:14:26 EST


On Tue, Feb 16, 2010 at 04:44:54PM -0600, Serge Hallyn wrote:
> From: Serge E. Hallyn <serue@xxxxxxxxxx>
>
> fsuid should always trail euid changes. So p9auth should
> set fsuid as well when it sets ruid and euid. Whether the
> suid should also be set is an open question - keeping the
> old uid in suid may be useful, or may just serve to trick
> lazy userspace.
>
> Note that so long as we do not also set suid, the setuid_fixup()
> code will not (when we later switch to setresuid()) fully
> fill/clear capability sets. So while I had previously thought
> that keeping suid unchanged would be useful, I think it is
> better to change all uids.

What is your goal for the p9auth code? Currently it is deleted in
linux-next due to a lack of development. I see you have some cleanup
patches, but I can't apply them unless you get the non-staging patches
accepted.

If I bring the driver back from deletion, will you work to fix it up and
get it merged into mainline?

What's the word on the non-staging patches in this series being
accepted?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/