Re: [Patch] mqueue: fix the bad code in sys_mq_open()

From: AmÃrico Wang
Date: Thu Feb 25 2010 - 11:13:13 EST


On Thu, Feb 25, 2010 at 12:41:47PM -0300, Andrà Goddard Rosa wrote:
>Hi, AmÃrico!
>
...
>I have some questions below:
>
>Inside do_open() and do_create() on mqueue.c, we call
>dentry_open()/__dentry_open().
>
>If dentry_open() fails, it'll automatically call:
> dput(dentry);
> mntput(mnt);
>

Oh, I trusted the current code too much, clearly this needs to be fixed
too. I already checked the 14 callers of dentry_open(), and will send
out a patchset to fix this tomorrow. (And the mqueue part will be based
on your patch.)

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/