Re: [RFC] driver-core: Add device node pointer to struct device

From: Greg KH
Date: Wed Feb 24 2010 - 16:49:14 EST


On Wed, Feb 24, 2010 at 02:10:30PM -0700, Grant Likely wrote:
> Greg and Kay,
>
> This is a patch from a larger series of OF related cleanup patches. This
> one adds a new 'of_node' member to struct device, conditional upon
> CONFIG_OF. The goal is to move of_node out of archdata because all
> arches using CONFIG_OF need it.
>
> Before I commit too much effort down this path, I want to get your
> feedback. Do you have any objections to this change to struct device?
>
> @@ -414,6 +415,9 @@ struct device {
> override */
> /* arch specific additions */
> struct dev_archdata archdata;
> +#ifdef CONFIG_OF
> + struct device_node *of_node;
> +#endif

No objection from me, but do we really need the #ifdef here?

> Full patch follows...

Do you want to take this patch through your tree? If so, feel free to
add:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

to the patch.

If not, let me know and I'll take it through my tree.

Glad to see this work coming along, nice job.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/