Re: linux-next: build failure after merge of the scsi tree

From: Stephen Rothwell
Date: Mon Feb 15 2010 - 19:38:27 EST


Hi James,

On Wed, 10 Feb 2010 17:16:16 -0500 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 2010-02-10 at 12:33 +1100, Stephen Rothwell wrote:
> >
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > drivers/scsi/lpfc/lpfc_bsg.c: In function 'lpfc_bsg_diag_mode':
> > drivers/scsi/lpfc/lpfc_bsg.c:1496: error: implicit declaration of function 'msleep'
> >
> > Caused by commit 3b5dd52aaffd291edea9f939ed46a960b240bb45 ("[SCSI] lpfc
> > 8.3.8: (BSG4) Add new vendor specific BSG Commands").
> >
> > Missing include of linux/delay.h?
>
> Looks to be exactly the problem. delay.h gets pulled into some of the
> generic headers on x86, but not on ppc.
>
> Sorry, my powerstation isn't working (orange warning light) and I can't
> seem to get anyone to repair it, so I can't build for ppc anymore (which
> is why this didn't get spotted on commit).

This is still broken ...
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature