Re: [PATCH v4 4/7] tcp: input header length, prediction, and timestampbugs

From: William Allen Simpson
Date: Mon Feb 15 2010 - 16:24:21 EST


Andi Kleen wrote:
On Mon, Feb 15, 2010 at 02:03:34PM -0500, William Allen Simpson wrote:
Andi Kleen wrote:
Is this a bug fix?

Yes. One of many, all inter-related.

It's useful to distingush bug fixes from cleanups from optimizations etc.
...

The bug fixes depend on the cleanups.
* 1/7 has the new functions.
* 2/7 has bug fixes that require the new functions.
* 3/7 fixes (and optimizes) the incoming code path, so that
* 4/7 can fix the bugs.
* 5/7 is needed to test the code from part 1.
* 6/7 is the cleanup of parsing (also fixes some bugs introduced by
davem's patch in December), so that
* 7/7 can fix the bugs.

I originally tried submitting these as separate individual pairs of
patches (in November, December, January), but nobody paid any attention.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/