Re: [PATCH][trace-cmd] parse-events: Make input buffer const char *

From: Johannes Berg
Date: Sat Feb 13 2010 - 06:22:23 EST


On Fri, 2010-02-12 at 19:53 -0500, Steven Rostedt wrote:

> I just wanted you to see a recent change I made. It touches your work
> around you added for the older kernels that did not convert your macro
> to a string. I'm sending this to you to make sure that it still works
> for your liking.

Heh, that means I'd have to test it? :)

> Also, I think I see a bug in the original code (and I kept) where you
> added a \ to %s. Perhaps its not a bug, but is it really needed? We
> don't process this code through any printf formatting.

Looks like a typo.

Patch _looks_ good otherwise, I'll give it a try when I find a file or
get one from a user.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part