Re: bug and question in tcp stack

[David Miller]

From: Joe Cao <caoco2002@xxxxxxxxx>
Date: Fri, 12 Feb 2010 15:22:16 -0800 (PST)

> if (tcp_retransmit_skb(sk, tcp_write_queue_head(sk)) > 0) {
> 
> checks the return value as a positive number, which will never be true.

It can, recheck the code paths.

The upcall to send an SKB out through the packet schedular and onwards
to the actual device can return congestion notification values, which
are positive.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/