Re: [PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.

[Luis R. Rodriguez]

On Fri, Feb 12, 2010 at 10:47 AM, Greg KH <gregkh@xxxxxxx> wrote:
> On Fri, Feb 12, 2010 at 05:55:34PM +0000, Hank Janssen wrote:
>>
>> > >
>> > > Âdrivers/staging/hv/VersionInfo.h | Â 22 +++++++++++++++++++---
>> >
>> > You forgot a "---" between the signed-off-by and the diffstat. ÂIf you
>> > use either git or quilt, it will get this correct automagically. ÂThat
>> > infers you used something else, which is quite scary. ÂWhat are you
>> > using instead to create patches?
>> >
>> > Don't worry, I can edit this by hand when I apply it, and will do so in
>> > a few days when I get to my "to-apply" queue, but in the future, please
>> > don't do this.
>> >
>> > thanks,
>> >
>> > greg k-h
>>
>> This must have been the result of a cut/paste error on my side.
>>
>> I use the following command for my diff  'git diff -M -u --stat'
>
> What's wrong with 'git format-patch'?
>
> You are creating a "raw" diff, which is fine, but you then need to
> include the rest of the comments. ÂIf you commit the patch to a branch,
> with the comments in them, then you can just automatically create the
> patches in correct format.

In case this helps:

http://wireless.kernel.org/en/developers/Documentation/git-guide

Toward s the end there is a git format-patch blurb and explains how to
set up your e-mail client with ssmpt.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/