Re: [fuse-devel] [PATCH] FUSE/CUSE: implement direct mmap support

[Tejun Heo]

Hello,

On 02/12/2010 10:53 PM, Miklos Szeredi wrote:
> That dev_offset value is used as an offset into the server side mmap
> address space.  And yes, vma->vm_pgoff and dev_offset should be SHMLBA
> multiples apart.

Alright.

> But don't call that _adjustment_.  That's totally confusing, these are
> *two* *different* *offsets*.

At this point, we're completely in the realm of the babel tower.
Unless we define all the terms explicitly, I don't think using or not
using a single word would make much difference.  Working with FUSE
gets a bit confusing regarding which term means what but with
multiple process address spaces and the dmmap address space and all
the offsets, it's getting pretty ridiculous.

> There's an alignment requirement but that's all.  If they are the
> same that is pure coincidence.
>
> And dev_offset (which points into the dmmap address space) is only
> required if the filesystem/CUSE driver needs server side mmap.

Hmmm... w/o the dev_offset how would the server designate which area
to use for the client?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/