Re: [RESEND][PATCHv2 4/4] OMAP: DSS2: Add Innolux 7" display forDEVKIT8000

[Tomi Valkeinen]

On Fri, 2010-02-12 at 06:55 +0100, ext Jaya Kumar wrote:
> On Fri, Feb 12, 2010 at 3:41 AM, Thomas Weber <swirl@xxxxxx> wrote:

[snip]

> > +
> > +static struct omap_video_timings innolux_at_timings = {
> > +       .x_res          = 800,
> > +       .y_res          = 480,
> > +
> > +       .pixel_clock    = 40000,
> > +
> > +       .hsw            = 48,
> > +       .hfp            = 1,
> > +       .hbp            = 1,
> > +
> > +       .vsw            = 3,
> > +       .vfp            = 12,
> > +       .vbp            = 25,
> > +};
> > +
> > +static int innolux_at_panel_probe(struct omap_dss_device *dssdev)
> > +{
> > +       dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> > +               OMAP_DSS_LCD_IHS;
> > +       dssdev->panel.acb = 0x28;
> > +       dssdev->panel.timings = innolux_at_timings;
> > +
> > +       return 0;
> > +}
> > +
> 
> Hi Thomas, Tomi,
> 
> Just curious, does this patch imply that code like this needs to be
> written for every single LCD type and resolution that can be connected
> to omap2? Maybe there is a better way, like a common table of timings
> and values that can be selected with a module option or even
> autodetected.

Yes, it is true that currently you need to write these for every LCD. I
have been thinking this issue, and I think we can make a common driver. 

However, it's not just selecting timings, as LCDs can have also other
characteristics than just the video timings. For example, some may have
power on/off line, some reset enable/disable, some need 50ms after
reset, some 80ms after reset etc.

But if we manage to get a sane set of those settings into the table, we
could perhaps cover most of the "dummy" LCDs with it.

This change doesn't probably need any changes to the DSS core, only for
the panel driver. Any takers for this task? =) 

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/