Re: mmotm 2010-02-10-16-17 uploaded (timberdale)

[Andrew Morton]

On Wed, 10 Feb 2010 18:43:33 -0800
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On 02/10/10 16:17, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://zen-kernel.org/kernel/mmotm.git
> > 
> > It contains the following patches against 2.6.33-rc7:
> 
> 
> When CONFIG_GPIOLIB is not enabled:
> 
>   CC      drivers/mfd/timberdale.o
> In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
> mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
> make[3]: *** [drivers/mfd/timberdale.o] Error 1
> 
> 
> Build error observed on i386 and on x86_64.
> 

Bug is in mainline too, I think.

Something like this?

--- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
+++ a/drivers/gpio/Kconfig
@@ -92,7 +92,7 @@ comment "I2C GPIO expanders:"
 
 config GPIO_MAX7300
 	tristate "Maxim MAX7300 GPIO expander"
-	depends on I2C
+	depends on I2C && GPIOLIB
 	select GPIO_MAX730X
 	help
 	  GPIO driver for Maxim MAX7301 I2C-based GPIO expander.
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/