[tip:x86/urgent] x86, ia32_aout: do not kill argument mapping

From: tip-bot for Jiri Slaby
Date: Wed Feb 10 2010 - 16:32:53 EST


Commit-ID: 318f6b228ba88a394ef560efc1bfe028ad5ae6b6
Gitweb: http://git.kernel.org/tip/318f6b228ba88a394ef560efc1bfe028ad5ae6b6
Author: Jiri Slaby <jslaby@xxxxxxx>
AuthorDate: Wed, 10 Feb 2010 20:55:16 +0100
Committer: H. Peter Anvin <hpa@xxxxxxxxx>
CommitDate: Wed, 10 Feb 2010 12:03:34 -0800

x86, ia32_aout: do not kill argument mapping

Do not set current->mm->mmap to NULL in 32-bit emulation on 64-bit
load_aout_binary after flush_old_exec as it would destroy already
set brpm mapping with arguments.

Introduced by b6a2fea39318e43fee84fa7b0b90d68bed92d2ba
mm: variable length argument support
where the argument mapping in bprm was added.

[ hpa: this is a regression from 2.6.22... time to kill a.out? ]

Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
LKML-Reference: <1265831716-7668-1-git-send-email-jslaby@xxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ollie Wild <aaw@xxxxxxxxxx>
Cc: x86@xxxxxxxxxx
Cc: <stable@xxxxxxxxxx>
Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>
---
arch/x86/ia32/ia32_aout.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c
index f9f4724..14531ab 100644
--- a/arch/x86/ia32/ia32_aout.c
+++ b/arch/x86/ia32/ia32_aout.c
@@ -327,7 +327,6 @@ static int load_aout_binary(struct linux_binprm *bprm, struct pt_regs *regs)
current->mm->free_area_cache = TASK_UNMAPPED_BASE;
current->mm->cached_hole_size = 0;

- current->mm->mmap = NULL;
install_exec_creds(bprm);
current->flags &= ~PF_FORKNOEXEC;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/