Re: [PATCH] sysfs: differentiate between locking links andnon-links

From: David Rientjes
Date: Tue Feb 09 2010 - 22:19:17 EST


On Wed, 10 Feb 2010, AmÃrico Wang wrote:

> > You should be able to reuse Neil's sysfs_dirent_init_lockdep(sd, type) to
> > seperate the lock classes for the sd getting pinned in
> > sysfs_get_active_two() from sysfs_deactivate(), although using subclasses
> > would probably be optimal since there is a clear parent -> child relationship.
>
> Yeah, basically, my fix is also adding a separate lockdep class, but
> at a different
> level. I will send the fix as soon as I finish it.
>

They shouldn't be entirely seperate classes for your "mutable" cases since
there will always be a parent -> child relationship, they should be
subclasses under the same lockclass at a SINGLE_DEPTH_NESTING level.