Re: [PATCH] thinkpad-acpi: setup hotkey polling after changinghotkey_driver_mask

From: Henrique de Moraes Holschuh
Date: Tue Feb 09 2010 - 20:28:32 EST


On Tue, 09 Feb 2010, Thadeu Lima de Souza Cascardo wrote:
> Sorry for the delay. Takes a while to build a kernel in my old notebook
> with a not-so-large config.

Heh, I know how you feel. Maybe you can use distcc to offload the worst of
the work to a more powerful box?

> It works nice for me. This was a fix that has crossed my mind, but since
> other init was doing the other way (hotkey_init), I did prefer that too.
> Anyway, your way is cleaner and the right way. :-)

hotkey_* kinda "owns" the event interface, so it is allowed some liberties I
try to avoid in the other parts of the driver :)

> Tested-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx>

Thank you. I will forward it to Len.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/