Re: [PATCH 17/35] sparsemem: put mem map for one node together.

From: Andrew Morton
Date: Tue Feb 09 2010 - 15:22:54 EST


On Tue, 09 Feb 2010 11:32:28 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> +#ifdef CONFIG_NO_BOOTMEM
> + free_early(__pa(vmemmap_buf_start), __pa(vmemmap_buf_end));
> + if (vmemmap_buf_start < vmemmap_buf) {
> + char name[15];
> +
> + memset(name, 0, sizeof(name));

Is the memset actually needed?

> + snprintf(name, 15, "MEMMAP %d", nodeid);

s/15/sizeof(name)/

> + reserve_early_without_check(__pa(vmemmap_buf_start),
> + __pa(vmemmap_buf), name);
> + }
> +#else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/