Re: PROBLEM: iwlagn kernel 2.6.32.3 ooops

From: Stanislaw Gruszka
Date: Tue Feb 09 2010 - 11:55:33 EST


On Mon, Feb 08, 2010 at 02:31:18PM -0800, Andrew Morton wrote:
> On Sat, 6 Feb 2010 18:03:50 +0100
> lkml@xxxxxxxxxxxxxxx wrote:
>
> > Hi,
>
> Suitable cc's added, more below...
>
> > This ooops happens on kernel 2.6.32.3. On a .32.7 it didn't
> > happen yet. Maybe fixed, maybe not.
> >
> > Keywords (i.e., modules, networking, kernel):
> > iwlagn, kernel 2.6.32.3
> >
> >
> > Below two msgs:
> > The first is the ooops that occurred when using the box as usual (IRC: after
> > this crash no rmmod && modprobe have been possible).
> >
> > The second - IRC - when the iwlagn module crashed, rebooted, crashed differently,
> > was then removed after the different ooops and re-modprobed.
> >
> >
> > [250420.677157] ip: page allocation failure. order:3, mode:0x8020
>
> This one isn't an "oops" - it's a warning that a memory allocation
> attempt failed. Which is hardly surprising: an order-3 GFP_ATOMIC
> allocation is highly unreliable and the driver just shouldn't be
> attempting it.
>
> > [250420.677168] Pid: 11584, comm: ip Not tainted 2.6.32.3 #5
> > [250420.677173] Call Trace:
> > [250420.677190] [<c10a53f8>] ? __alloc_pages_nodemask+0x518/0x5f0
> > [250420.677204] [<c1007c20>] ? dma_generic_alloc_coherent+0x0/0x100
> > [250420.677214] [<c1007c92>] ? dma_generic_alloc_coherent+0x72/0x100
> > [250420.677224] [<c1007c20>] ? dma_generic_alloc_coherent+0x0/0x100
> > [250420.677241] [<fca1c9d5>] ? iwl_tx_queue_init+0x285/0x380 [iwlcore]

That is at initialization time. To avoid atomic allocation we can just
use dma_alloc_coherent instead of pci_alloc_consistent. I'm going to
prepare a patch.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/