Re: [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc iniwm_mlme_update_bss_table()

[Samuel Ortiz]

On Tue, 2010-02-09 at 12:07 +0100, Roel Kluin wrote:
> The wrong pointer was tested.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>


> ---
>  drivers/net/wireless/iwmc3200wifi/rx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
> index 6d6ed74..f727b4a 100644
> --- a/drivers/net/wireless/iwmc3200wifi/rx.c
> +++ b/drivers/net/wireless/iwmc3200wifi/rx.c
> @@ -794,7 +794,7 @@ static int iwm_mlme_update_bss_table(struct iwm_priv *iwm, u8 *buf,
>  	}
>  
>  	bss->bss = kzalloc(bss_len, GFP_KERNEL);
> -	if (!bss) {
> +	if (!bss->bss) {
>  		kfree(bss);
>  		IWM_ERR(iwm, "Couldn't allocate bss\n");
>  		return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/