Re: [PATCH 1/1] thinkpad-acpi: fix link error to include sound arch

[Henrique de Moraes Holschuh]

On Tue, 19 Jan 2010, Hagen Paul Pfeifer wrote:
> On Tue, 19 Jan 2010 12:51:08 -0200, <hmh@xxxxxxxxxx> wrote:
> > Can you describe the problem in more detail?  That will save me precious
> > time, as I am rather overworked right now...
> 
> If you build the sound as a module and thinkpad as a build-in component
> the linker will complain about missing symbols. So the right fix may

This is not supposed to be possible anymore, and in fact, I can't force
that breakage to happen in 2.6.33-rc6.

> be a patch that 1) enforces the sound component to be build static or
> to enforces thinkpad apic to be build as a module. Another way 2) is

Currently, the Kconfig disables ALSA support for thinkpad-acpi static
and ALSA as module, but allows static-static or module-module.

> Any other ideas Henrique?

No, you're correct, but the fix was already in its way to mainline when
you sent your report.  I took some time to try to break it today, just
in case there was something I missed.

What kernel was giving you trouble? I still need to fix the backports in
the thinkpad-acpi git tree, maybe it was one of them?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/