Re: BUG: sched_mc_powersavings broken on pre-Nehalem x86 platforms

[Vaidyanathan Srinivasan]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2010-02-08 12:35:48]:

> On Mon, 2010-02-08 at 15:35 +0530, Vaidyanathan Srinivasan wrote:
> 
> >     Fix for sched_mc_powersavigs for pre-Nehalem platforms.
> >     Child sched domain should clear SD_PREFER_SIBLING if parent will have 
> >     SD_POWERSAVINGS_BALANCE because they are contradicting.
> > 
> >     Sets the flags correctly based on sched_mc_power_savings.
> >     
> >     Signed-off-by: Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx>
> > 
> > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > index 6550415..ef6b7cd 100644
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -866,7 +866,10 @@ static inline int sd_balance_for_mc_power(void)
> >  	if (sched_smt_power_savings)
> >  		return SD_POWERSAVINGS_BALANCE;
> >  
> > -	return SD_PREFER_SIBLING;
> > +	if (!sched_mc_power_savings)
> > +		return SD_PREFER_SIBLING;
> > +
> > +	return 0;
> >  }
> >  
> >  static inline int sd_balance_for_package_power(void)
> > 
> 
> Looks good, thanks!
> 
> What's the status of getting rid of sched_{mc,smt}_power_savings?

Hi Peter,

With the current rearrangement of the code, the unified
sched_power_savings seems more doable.

However, I have few more fixes for sched_smt_powersavings on Nehalem
before I would revisit the unified tunable.

--Vaidy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/