Re: [RFC][RFT][PATCH] ACPI: Protection from suspending in the middle of EC transaction

From: Rafael J. Wysocki
Date: Sun Jan 31 2010 - 16:08:57 EST


On Sunday 31 January 2010, Maxim Levitsky wrote:
> On Sun, 2010-01-31 at 00:29 +0100, Rafael J. Wysocki wrote:
...
> >
> > static int acpi_ec_resume(struct acpi_device *device)
> > {
> > struct acpi_ec *ec = acpi_driver_data(device);
> > +
> > + mutex_lock(&ec->lock);
> > /* Enable use of GPE back */
> > acpi_enable_gpe(NULL, ec->gpe);
> > + /* Allow transactions to happen again */
> > + set_bit(EC_FLAGS_SUSPENDED, &ec->flags);
> ^^^^^^^^^^^^
> Thats why it doesn't work here....
> Will retest now.

Ouch, sorry.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/