Re: Radeon KMS regression still present in 2.6.33-rc6

From: John Kacur
Date: Sat Jan 30 2010 - 15:50:11 EST


On Sat, Jan 30, 2010 at 8:54 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> On Sat, 30 Jan 2010, Johannes Hirte wrote:
>>
>> This is caused by commit 42590a75019a50012f25a962246498dead42843
>>
>> Fix is already posted:
>>
>> http://marc.info/?l=linux-kernel&m=126428141429200&w=2
>
> Goodie. Kevin, can you test the patch from FUJITA Tomonori in that thread
> ("http://marc.info/?l=linux-kernel&m=126439631307219&w=2"; to be exact).
>

The little hunk of code that Kevin posted is also the source of a new
warning in -rc6,
which is easily fixed. (following up with a patch)

Assuming the patch in that link fixes the problem, the order of the
check of the aper_size in
radeon_agp_init appears incorrect to me. Also following up with a patch.

John Kacur
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/