Re: [Patch 0/2] sysfs: fix s_active lockdep warning

From: Peter Zijlstra
Date: Fri Jan 29 2010 - 13:15:26 EST


On Fri, 2010-01-29 at 10:10 -0800, Greg KH wrote:
> On Fri, Jan 29, 2010 at 06:57:28PM +0100, Peter Zijlstra wrote:
> > On Fri, 2010-01-29 at 06:22 -0800, Greg KH wrote:
> > >
> > > Heh, this whole mess is the very reason we didn't add lockdep support to
> > > the driver core. Nested devices that all look alike from the driver
> > > core, are really different objects and the locking lifetimes are
> > > separate, but lockdep can't see that.
> >
> > And here I through Alan Stern had a handle on making the driver core
> > play nice.
>
> It's not the driver core that is the issue here, it's that lockdep can't
> handle the tree structure of devices that is represented in the kernel.
>
> I don't think it is a driver core problem, but rather, a lockdep issue.

Right, we've been over that and I think I added enough lockdep
annotations to make it work for the device tree. At least, Alan and I
seemed to agree on that last time we talked about it.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/