Re: [PATCH tracing/kprobes] kprobes: Disable booster whenCONFIG_PREEMPT=y

From: Mathieu Desnoyers
Date: Fri Jan 29 2010 - 12:13:26 EST


* Masami Hiramatsu (mhiramat@xxxxxxxxxx) wrote:
> Ingo Molnar wrote:
> >
> > * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >
> >> Disable kprobe booster when CONFIG_PREEMPT=y, because it can't ensure that
> >> all kernel threads preempted on kprobe's boosted slot run out from the slot
> >> even using freeze_processes().
> >
> > hm, this really sucks as it makes preemptible kernels perform worse. Is there
> > no better solution?
> >
> >> The booster on preemptive kernel will be resumed if synchronize_tasks() or
> >> something like that is introduced.
> >
> > such as this one?
>
> Yes, I think this synchronize_tasks(), which just (sleeping) wait until
> all currently preempted tasks are wake up and scheduled, can ensure safety

If a task is set as stopped, and the preempted before calling schedule,
can this result in a preempted task staying in that state for an
arbitrary long period of time ? Or is there some mechanism prohibiting
that in the scheduler ?

Thanks,

Mathieu

>
> Thank you,
>
> --
> Masami Hiramatsu
>
> Software Engineer
> Hitachi Computer Products (America), Inc.
> Software Solutions Division
>
> e-mail: mhiramat@xxxxxxxxxx
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/