Re: [PATCH 04/11] VT-d: Change {un}map_range functions toimplement {un}map interface

[Joerg Roedel]

On Fri, Jan 29, 2010 at 09:59:42AM +1300, David Woodhouse wrote:
> On Thu, 2010-01-28 at 12:37 +0100, Joerg Roedel wrote:
> > This patch changes the iommu-api functions for mapping and
> > unmapping page ranges to use the new page-size based
> > interface. This allows to remove the range based functions
> > later. 
> 
> > +       size     = 0x1000UL << gfp_order;
> 
> Um, that's not a page-size based interface. Page size isn't always 4KiB;
> this code runs on IA64 too.
> 
> We have enough fun with CPU vs. DMA page size on IA64 already :)

Ah right. So this should be

	size     = PAGE_SIZE << gfp_order;

Right? The interface is meant to map the same amount of memory which
alloc_pages(gfp_order) would return. Same for the return value of the
unmap function.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/