Re: linux-next: driver-core tree build warning

From: Stephen Rothwell
Date: Fri Jan 29 2010 - 02:21:28 EST


Hi Greg,

On Thu, 21 Jan 2010 15:10:10 -0800 Greg KH <greg@xxxxxxxxx> wrote:
>
> Here's a patch that I just applied to my tree to hopefully resolve this
> issue.

I still get the warnings.

> -static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
> -static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> +static SYSDEV_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);

This defines attr_probe as a "struct sysdev_attribute" whose attr element
is a "struct attribute".

> +static SYSDEV_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */
>
> #else /* ... !CONFIG_HOTPLUG_CPU */
> @@ -261,8 +261,8 @@ int __init cpu_dev_init(void)
>
> static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
> #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> - &class_attr_probe.attr,
> - &class_attr_release.attr,
> + &attr_probe.attr,

so here we are initialising a "struct sysdev_class_attribute *" with a
"struct attribute *". Thus the warning.

> + &attr_release.attr,

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature