Re: [PATCH] perf: Add util/include/linux/config.h for includinggenerated autoconf.h of kernel

[Paul Mackerras]

On Thu, Jan 28, 2010 at 11:28:48PM +0900, Hitoshi Mitake wrote:

> I'd like to add util/include/linux/config.h,
> this header file includes autoconf.h which is generated
> by build phase of kernel.
> 
> This makes building of perf depend on building of kernel.
> It's a little dirty. But perf has tight relation
> of its kernel, so I don't think that it is a serious problem.
> 
> My original purpose of making this patch is
> knowing size of void *.
> If config.h is available,
> CONFIG_ARCH_PHYS_ADDR_T_64BIT will be provided for source of perf,
> we can know size of void * by this config.
> 
> How do you think?

How will this work if I built the kernel in a separate object
directory (e.g., using "make O=../builddir vmlinux")?  I think that
trying to include generated files will fail in that case.

In general I think that tying perf to the kernel config is a bad idea.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/