Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi_loader to hang

From: Oliver Neukum
Date: Thu Jan 28 2010 - 13:40:09 EST


Am Donnerstag, 28. Januar 2010 18:45:46 schrieb Greg KH:
> On Tue, Jan 19, 2010 at 02:20:29PM +0100, Oliver Neukum wrote:
> > Am Montag, 18. Januar 2010 21:14:16 schrieb Matthew Garrett:
> >
> > > drivers/usb/serial/generic.c: usb_serial_generic_write - port 0, 1565
> > > bytes
> > > drivers/usb/serial/generic.c: usb_serial_generic_write - put 0 bytes
> > > into fifo
> > > drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback -
> > > port 0
> >
> > If the FIFO is full we can do nothing. Please try the attached patch.
>
> Did we ever determine if the patch below is needed or not?

No. Further discussion cast serious doubt on it, but we have no
experimental evidence I am aware of.

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/