Re: [PATCH] drm/i915: Selectively enable self-reclaim

From: Roman Jarosz
Date: Thu Jan 28 2010 - 13:19:17 EST


On Thu, 28 Jan 2010 04:15:00 +0100, Michael Reinelt <michael@xxxxxxxxxxxxx> wrote:



Pekka Enberg schrieb:
Chris Wilson kirjoitti:
Having missed the ENOMEM return via i915_gem_fault(), there are probably
other paths that I also missed. By not enabling NORETRY by default these
paths can run the shrinker and take memory from the system (but not from
our own inactive lists because our shrinker can not run whilst we hold
the struct mutex) and this may allow the system to survive a little
longer
whilst our drivers consume all available memory.

References:
OOM killer unexpectedly called with kernel 2.6.32
http://bugzilla.kernel.org/show_bug.cgi?id=14933

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Cc: Eric Anholt <eric@xxxxxxxxxx>
Cc: stable@xxxxxxxxxx

Roman, can you give this patch a spin?

Applied to 2.6.33-rc5, stress-test under heavy load, no problem so far. Looks fine!

Here it works too, thanks!

Roman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/