Re: [PATCH] imxfb: correct location of callbacks in suspend andresume

From: Andrew Morton
Date: Wed Jan 27 2010 - 18:51:52 EST


On Mon, 25 Jan 2010 16:37:34 +0100
Uwe Kleine-K__nig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> The probe function passes a pointer to a struct fb_info to
> platform_set_drvdata, so don't interpret the return value of
> platform_get_drvdata as a pointer to struct imxfb_info.
>
> Signed-off-by: Uwe Kleine-K__nig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Acked-by: Sascha Hauer <kernel@xxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> drivers/video/imxfb.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 66358fa..b4b6dec 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -593,7 +593,8 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
> */
> static int imxfb_suspend(struct platform_device *dev, pm_message_t state)
> {
> - struct imxfb_info *fbi = platform_get_drvdata(dev);
> + struct fb_info *info = platform_get_drvdata(dev);
> + struct imxfb_info *fbi = info->par;
>
> pr_debug("%s\n", __func__);
>
> @@ -603,7 +604,8 @@ static int imxfb_suspend(struct platform_device *dev, pm_message_t state)
>
> static int imxfb_resume(struct platform_device *dev)
> {
> - struct imxfb_info *fbi = platform_get_drvdata(dev);
> + struct fb_info *info = platform_get_drvdata(dev);
> + struct imxfb_info *fbi = info->par;
>
> pr_debug("%s\n", __func__);
>

What were the runtime effects of this bug?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/