Re: [PATCH 2/4] perf,hw_breakpoint: add lockless reservation forhw_breaks

[Jason Wessel]

Frederic Weisbecker wrote:
> On Tue, Jan 26, 2010 at 01:25:19PM -0600, Jason Wessel wrote:
>   
>> @@ -250,11 +326,16 @@ int reserve_bp_slot(struct perf_event *b
>>  
>>  	mutex_lock(&nr_bp_mutex);
>>  
>> +	ret = dbg_hw_breakpoint_alloc(bp->cpu);
>> +	if (ret)
>> +		goto end;
>> +
>>     
>
>
>
> This is totally breaking all the constraints that try to
> make the reservation cpu-wide/task-wide aware.
>   

Agreed.  I was unaware of all the various pieces that the toggle_bp
handled.

A revised series is on the way based on the off-list discussion.

Thanks,
Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/