Re: + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patchadded to -mm tree

[Jiri Slaby]

On 01/27/2010 03:53 PM, Joe Perches wrote:
> Do feel free to submit patches with your
> desired level of changelog prolixity.

It's not my level changelog prolixity, it's you do changes irrelevant to
your changelog and further you do not explain, why you change the code.
So (a) review process is hard and (b) nobody (mainly distro kernel
packagers) knows whether to backport some of the change to stable or not.

Look at that piece again:
Subject	[PATCH 03/24] drivers/block/floppy.c: Use pr_<level>
Date	Thu, 21 Jan 2010 20:52:33 -0800

Convert bare printk to pr_info and pr_cont
Convert printk(KERN_ERR to pr_err
...
 	if (UDP->flags & FD_DEBUG) {
-		DPRINT("reschedule timeout ");
-		printk(message, marg);
-		printk("\n");
+		DPRINT("reschedule timeout %s %d\n", message, marg);
 	}

Does it look like a "Use pr_<level>" change? No and hence my confusion
by the hunk.

-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/