Re: [Stable-review] [20/98] atl1c:use common_task instead of reset_task and link_chg_task

[Willy Tarreau]

On Tue, Jan 26, 2010 at 03:33:46PM -0800, Greg KH wrote:
> From: Jie Yang <jie.yang@xxxxxxxxxxx>
> 
> commit cb19054697e92a793f336380fd72c588521178ff upstream.
> 
> use common_task instead of reset_task and link_chg_task, so it fix "call cancel_work_sync
> from the work itself".
> 
> Signed-off-by: Jie Yang <jie.yang@xxxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

I'm going to test this one. I'm randomly seeing my ASUS 1005HA
hanging after I replug the network cable. I noticed that the
driver from the Atheros site doesn't have the issue at all. I
spent a week-end trying to eliminate almost all of the diffs
between the two drivers to try to spot the faulty code chunk,
until I realized that I went past the failure point without
noticing in time because the issue was too much random :-(

Clearly a non-bisectable issue. But with just this fix, I'll
be able to tell if the problem is definitely over.

Regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/