[81/98] UBI: fix memory leak in update path

From: Greg KH
Date: Tue Jan 26 2010 - 18:48:42 EST


2.6.32-stable review patch. If anyone has any objections, please let us know.

------------------

From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>

commit ebddd63b74dcf1cb676d14328d5852f1fee19a8a upstream.

When truncating an UBI volume, UBI should allocates a PEB-sized
buffer but does not release it, which leads to memory leaks.
This patch fixes the issue.

Reported-by: Marek Skuczynski <mareksk7@xxxxxxxxx>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
Tested-by: Marek Skuczynski <mareksk7@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
drivers/mtd/ubi/upd.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/mtd/ubi/upd.c
+++ b/drivers/mtd/ubi/upd.c
@@ -155,6 +155,7 @@ int ubi_start_update(struct ubi_device *
if (err)
return err;
vol->updating = 0;
+ return 0;
}

vol->upd_buf = vmalloc(ubi->leb_size);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/