Re: [PATCH v2 1/2] cpufreq: ondemand: Refactor frequency increasecode

[Pallipadi, Venkatesh]

On Mon, 2010-01-25 at 17:47 -0800, Mike Chan wrote:
> Make simpler to read and call.
> 
> Signed-off-by: Mike Chan <mike@xxxxxxxxxxx>

Nack.
This patch seem to be changing the logic in the code. Comment inlined
below.

> ---
>  drivers/cpufreq/cpufreq_ondemand.c |   26 +++++++++++++-------------
>  1 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 4b34ade..3dcf126 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -443,6 +443,17 @@ static struct attribute_group dbs_attr_group_old = {
>  
>  /************************** sysfs end ************************/
>  
> +static int dbs_freq_increase(struct cpufreq_policy *p, unsigned int target_freq)
> +{
> +	if (dbs_tuners_ins.powersave_bias)
> +		target_freq = powersave_bias_target(p, target_freq,
> +				CPUFREQ_RELATION_H);
> +
> +	__cpufreq_driver_target(p, target_freq,
> +			dbs_tuners_ins.powersave_bias ?
> +			CPUFREQ_RELATION_L : CPUFREQ_RELATION_H);
> +}
> +
>  static void dbs_check_cpu(struct cpu_dbs_info_s *this_dbs_info)
>  {
>  	unsigned int max_load_freq;
> @@ -520,19 +531,8 @@ static void dbs_check_cpu(struct cpu_dbs_info_s *this_dbs_info)
>  
>  	/* Check for frequency increase */
>  	if (max_load_freq > dbs_tuners_ins.up_threshold * policy->cur) {
> -		/* if we are already at full speed then break out early */
> -		if (!dbs_tuners_ins.powersave_bias) {
> -			if (policy->cur == policy->max)
> -				return;
> -
> -			__cpufreq_driver_target(policy, policy->max,
> -				CPUFREQ_RELATION_H);
> -		} else {
> -			int freq = powersave_bias_target(policy, policy->max,
> -					CPUFREQ_RELATION_H);
> -			__cpufreq_driver_target(policy, freq,
> -				CPUFREQ_RELATION_L);
> -		}
> +		if (policy->cur != policy->max)
> +			dbs_freq_increase(policy, policy->max);


In case of powersave_bias, bias_target and driver_target was getting
called even for cur == max before. After this change, they wont be
getting called, which would be wrong.


Thanks,
Venki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/