Re: [RFC/PATCH 0/4] twl4030 threaded_irq support

From: David Brownell
Date: Tue Jan 26 2010 - 07:18:59 EST


On Tuesday 26 January 2010, Felipe Balbi wrote:
> >But nothing in drivers/mfd ... the entry to the whole stack?
> >...
>
> correct, that's still missing. I tried to play with it for a while, but
> had to give up due to other musb tasks. So if someone wants to step up
> and code that part, I'd be glad

I'm quite sure I sent a patch doing that ... sometime early last
summer, when the threaded IRQ stuff was being thrashed out! (To
show what it'd look like, and see what problems remained.) That
interface hasn't changed much since then, except for addition of
a stuff like ONESHOT support, set_irq_nested_thread(), and the
bus_lock stuff. It's surely in LKML archives. :)

My point here was more like: these patches shouldn't merge without
that top-level change. Just switch the whole current structure
(one thread, nesting) over to the now-standard interfaces at the
same time, not incrementally. Later, the bus_lock stuff can switch
over too (for cleaner mask/unmask).

That's clearly material for 2.6.34 though ...

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/