Re: [2.6.33-rc5] starting emacs makes lockdep warning

[AmÃrico Wang]

On Tue, Jan 26, 2010 at 11:20 AM, KOSAKI Motohiro
<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> Hi
>
> Current linus tree made following lockdep warning when starting emacs command.
> Is this known issue?
>
>
> =========================================================
> [ INFO: possible irq lock inversion dependency detected ]
> 2.6.33-rc5 #77
> ---------------------------------------------------------
> emacs/1609 just changed the state of lock:
> Â(&(&tty->ctrl_lock)->rlock){+.....}, at: [<ffffffff8127c648>] tty_fasync+0xe8/0x190
> but this lock took another, HARDIRQ-unsafe lock in the past:
> Â(&(&sighand->siglock)->rlock){-.....}
>
> and interrupts could create inverse lock ordering between them.
>
>

Hey,

does reverting commit 703625118 help?



> other info that might help us debug this:
> 1 lock held by emacs/1609:
> Â#0: Â(&(&tty->ctrl_lock)->rlock){+.....}, at: [<ffffffff8127c648>] tty_fasync+0xe8/0x190
>
> the shortest dependencies between 2nd lock and 1st lock:
> Â-> (&(&sighand->siglock)->rlock){-.....} ops: 50393 {
> Â ÂIN-HARDIRQ-W at:
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8108924e>] __lock_acquire+0x7ae/0x15a0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8108a0df>] lock_acquire+0x9f/0x120
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81423012>] _raw_spin_lock_irqsave+0x52/0x90
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81065799>] lock_task_sighand+0x79/0x100
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8106600f>] do_send_sig_info+0x3f/0x90
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff810660f0>] group_send_sig_info+0x40/0x50
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81066703>] kill_pid_info+0x73/0xe0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81054014>] it_real_fn+0x44/0xa0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81075d1e>] __run_hrtimer+0x8e/0x1e0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81076116>] hrtimer_interrupt+0xe6/0x250
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8142a0b9>] smp_apic_timer_interrupt+0x69/0x9b
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81003a93>] apic_timer_interrupt+0x13/0x20
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81001956>] cpu_idle+0x66/0xd0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff814082e2>] rest_init+0x92/0xa0
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81b4cd84>] start_kernel+0x3b9/0x3c5
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81b4c310>] x86_64_start_reservations+0x120/0x124
> Â Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81b4c3f8>] x86_64_start_kernel+0xe4/0xeb
> Â ÂINITIAL USE at:
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81088e86>] __lock_acquire+0x3e6/0x15a0
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8108a0df>] lock_acquire+0x9f/0x120
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81423012>] _raw_spin_lock_irqsave+0x52/0x90
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff810646dc>] flush_signals+0x2c/0x60
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81064743>] ignore_signals+0x33/0x40
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81071067>] kthreadd+0x37/0x180
> Â Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81003ed4>] kernel_thread_helper+0x4/0x10
> Â}
> Â... key   Âat: [<ffffffff81c054a4>] __key.46539+0x0/0x8
> Â... acquired at:
> Â [<ffffffff81089af6>] __lock_acquire+0x1056/0x15a0
> Â [<ffffffff8108a0df>] lock_acquire+0x9f/0x120
> Â [<ffffffff81423012>] _raw_spin_lock_irqsave+0x52/0x90
> Â [<ffffffff8127c1be>] __proc_set_tty+0x3e/0x150
> Â [<ffffffff8127e01d>] tty_open+0x51d/0x5e0
> Â [<ffffffff81142400>] chrdev_open+0x170/0x290
> Â [<ffffffff8113c561>] __dentry_open+0x131/0x3a0
> Â [<ffffffff8113c8e4>] nameidata_to_filp+0x54/0x70
> Â [<ffffffff8114c098>] do_filp_open+0x948/0xcd0
> Â [<ffffffff8113c2e9>] do_sys_open+0x69/0x140
> Â [<ffffffff8113c400>] sys_open+0x20/0x30
> Â [<ffffffff8100309b>] system_call_fastpath+0x16/0x1b
>
> -> (&(&tty->ctrl_lock)->rlock){+.....} ops: 191 {
> Â HARDIRQ-ON-W at:
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81087e63>] mark_held_locks+0x73/0xa0
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff810880bb>] trace_hardirqs_on_caller+0x7b/0x1c0
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8108820d>] trace_hardirqs_on+0xd/0x10
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff81423730>] _raw_write_unlock_irq+0x30/0x60
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8114cc63>] f_modown+0x53/0xe0
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8114cd1e>] __f_setown+0xe/0x20
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8127c667>] tty_fasync+0x107/0x190
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8114d842>] sys_fcntl+0x222/0x580
> Â Â Â Â Â Â Â Â Â Â Â Â[<ffffffff8100309b>] system_call_fastpath+0x16/0x1b
> Â INITIAL USE at:
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81088e86>] __lock_acquire+0x3e6/0x15a0
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8108a0df>] lock_acquire+0x9f/0x120
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81423012>] _raw_spin_lock_irqsave+0x52/0x90
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8127c1be>] __proc_set_tty+0x3e/0x150
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8127e01d>] tty_open+0x51d/0x5e0
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff81142400>] chrdev_open+0x170/0x290
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8113c561>] __dentry_open+0x131/0x3a0
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8113c8e4>] nameidata_to_filp+0x54/0x70
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8114c098>] do_filp_open+0x948/0xcd0
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8113c2e9>] do_sys_open+0x69/0x140
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8113c400>] sys_open+0x20/0x30
> Â Â Â Â Â Â Â Â Â Â Â [<ffffffff8100309b>] system_call_fastpath+0x16/0x1b
> Â}
> Â... key   Âat: [<ffffffff82533fb8>] __key.30033+0x0/0x8
> Â... acquired at:
> Â [<ffffffff81087263>] check_usage_backwards+0x93/0x100
> Â [<ffffffff81087b9a>] mark_lock+0x1ca/0x420
> Â [<ffffffff81087e63>] mark_held_locks+0x73/0xa0
> Â [<ffffffff810880bb>] trace_hardirqs_on_caller+0x7b/0x1c0
> Â [<ffffffff8108820d>] trace_hardirqs_on+0xd/0x10
> Â [<ffffffff81423730>] _raw_write_unlock_irq+0x30/0x60
> Â [<ffffffff8114cc63>] f_modown+0x53/0xe0
> Â [<ffffffff8114cd1e>] __f_setown+0xe/0x20
> Â [<ffffffff8127c667>] tty_fasync+0x107/0x190
> Â [<ffffffff8114d842>] sys_fcntl+0x222/0x580
> Â [<ffffffff8100309b>] system_call_fastpath+0x16/0x1b
>
>
> stack backtrace:
> Pid: 1609, comm: emacs Not tainted 2.6.33-rc5 #77
> Call Trace:
> Â[<ffffffff810870bd>] print_irq_inversion_bug.clone.0+0x12d/0x140
> Â[<ffffffff810871d0>] ? check_usage_backwards+0x0/0x100
> Â[<ffffffff81087263>] check_usage_backwards+0x93/0x100
> Â[<ffffffff8114cc4c>] ? f_modown+0x3c/0xe0
> Â[<ffffffff81087b9a>] mark_lock+0x1ca/0x420
> Â[<ffffffff81087e63>] mark_held_locks+0x73/0xa0
> Â[<ffffffff81423730>] ? _raw_write_unlock_irq+0x30/0x60
> Â[<ffffffff810880bb>] trace_hardirqs_on_caller+0x7b/0x1c0
> Â[<ffffffff8108820d>] trace_hardirqs_on+0xd/0x10
> Â[<ffffffff81423730>] _raw_write_unlock_irq+0x30/0x60
> Â[<ffffffff8114cc63>] f_modown+0x53/0xe0
> Â[<ffffffff8114cd1e>] __f_setown+0xe/0x20
> Â[<ffffffff8127c667>] tty_fasync+0x107/0x190
> Â[<ffffffff8114d842>] sys_fcntl+0x222/0x580
> Â[<ffffffff8100309b>] system_call_fastpath+0x16/0x1b
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/