Re: locking design for task_subsys_state()?

From: Paul Menage
Date: Mon Jan 25 2010 - 21:08:59 EST


On Sun, Jan 24, 2010 at 3:25 PM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> Is there some flag in the task structure that I should check in order to
> suppress this splat, and, more important, to document the locking
> design?  Here is what I currently have in my local tree:

Nothing cgroup-specific as far as I know - I guess it's just assumed
that since nothing else can be accessing the task_struct at that point
as it's not linked into any lists (is that correct?) then there's no
locking needed. If there's no generic task flag that indicates that
the task has never been exposed to any other thread via a list, etc,
it could be added? I imagine that some other subsystems are likely to
have similar problems. Alternatively, adding an RCU read-lock pair
around the relevant code is probably possible too, even if not
technically necessary.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/