Re: [PATCH 5/8] percpu: add __percpu sparse annotations to x86

From: H. Peter Anvin
Date: Mon Jan 25 2010 - 20:19:19 EST


On 01/25/2010 07:22 AM, Tejun Heo wrote:
>
> In arch/x86/kernel/cpu/common.c, per_cpu(exception_stacks, cpu) is
> replaced with &per_cpu(exception_stacks[0], cpu) which is equivalent
> except that it allows per_cpu() macro to correctly drop percpu
> designation during sparse pass.
>

Same comment as Frederic's about this... this kind of uglification
really is unacceptable and needs to be addressed.

Other than that, it looks good.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/