Re: [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is used

From: Rafael J. Wysocki
Date: Mon Jan 25 2010 - 16:53:53 EST


On Monday 25 January 2010, Alan Cox wrote:
> > > But in that case we should be able to disable the VT switch disable
> > > path; we just have to check each driver as it's loaded.
> >
> > OK, what the right sequence of checks would be in that case and where to place
> > them?
>
> Why are we even driving a vt switch direct from the suspend/resume
> logic ? The problem starts there. If it was being handled off the device
> suspend/resume method then there wouldn't be a mess to start with ?
>
> Start at the beginning
>
> - Why do we switch to arbitarily chosen 'last vt'
> - Why isn't vt related suspend/resume handled by the device

Well, that was added long ago as a workaround for some problems people
reported (presumably). I've never looked at that before, so I can't really
tell why someone did it this particular way.

Obviously I'd like to clean it up, though.

So, what device should handle this in your opinion?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/