Re: [PATCH 2/9] drivers/misc: Eliminate useless code

From: Tomas Winkler
Date: Sat Jan 23 2010 - 14:43:40 EST


On Sat, Jan 16, 2010 at 5:57 PM, Julia Lawall <julia@xxxxxxx> wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> The variable priv is initialized twice to the same (side effect-free)
> expression. ÂDrop one initialization.
>
> A simplified version of the semantic match that finds this problem is:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @forall@
> idexpression *x;
> identifier f!=ERR_PTR;
> @@
>
> x = f(...)
> ... when != x
> (
> x = f(...,<+...x...+>,...)
> |
> * x = f(...)
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
Acked-by Tomas.Winker <tomas.winkler@xxxxxxxxx>


I appreciate if you CC me next time.

Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/