Re: [PATCH v2] ftrace: unify arch_syscall_addr() implementations

[Mike Frysinger]

On Sat, Jan 23, 2010 at 03:28, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Mike Frysinger <vapier@xxxxxxxxxx>
> Date: Sat, 23 Jan 2010 02:10:43 -0500
>
>> Most implementations of arch_syscall_addr() are the same, so create a
>> default weak version in common code. ÂNew arch ports don't have to waste
>> time copying & pasting this simple function. ÂThe Blackfin version is
>> going to be exactly the same for example.
>>
>> The s390/sparc versions need to be different, so document why.
>>
>> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
>
> You can just have the extern declaration match whatever the
> arch needs (long or int) in the generic ftrace.c code and
> then unconditionally do the (unsigned long) case.
>
> That way even s390/sparc can use the generic implementation.

asm/syscall.h is the most reasonable location to move the decls to in
asm/ ... people OK with that ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/