Re: [PATCH] Add Xeon 7500 series support to oprofile

From: John Villalovos
Date: Fri Jan 22 2010 - 11:23:19 EST


On Thu, Jan 21, 2010 at 5:26 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> Add Xeon 7500 series support to oprofile
>
> Straight forward: it's the same as Core i7, so just detect
> the model number. No user space changes needed.
>
> Very simple patch, so it could be still merged for .33?
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> ---
> Âarch/x86/oprofile/nmi_int.c | Â Â1 +
> Â1 file changed, 1 insertion(+)
>
> Index: linux/arch/x86/oprofile/nmi_int.c
> ===================================================================
> --- linux.orig/arch/x86/oprofile/nmi_int.c
> +++ linux/arch/x86/oprofile/nmi_int.c
> @@ -598,6 +598,7 @@ static int __init ppro_init(char **cpu_t
> Â Â Â Âcase 15: case 23:
> Â Â Â Â Â Â Â Â*cpu_type = "i386/core_2";
> Â Â Â Â Â Â Â Âbreak;
> + Â Â Â case 0x2e:
> Â Â Â Âcase 26:
> Â Â Â Â Â Â Â Âspec = &op_arch_perfmon_spec;
> Â Â Â Â Â Â Â Â*cpu_type = "i386/core_i7";

How about: this instead?

Signed-off-by: John L. Villalovos <john.l.villalovos@xxxxxxxxx>

diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
index cb88b1a..edc074c 100644
--- a/arch/x86/oprofile/nmi_int.c
+++ b/arch/x86/oprofile/nmi_int.c
@@ -598,7 +598,7 @@ static int __init ppro_init(char **cpu_type)
case 15: case 23:
*cpu_type = "i386/core_2";
break;
- case 26:
+ case 26: case 46:
spec = &op_arch_perfmon_spec;
*cpu_type = "i386/core_i7";
break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/