Re: [patch] perf tools: fix dc8d6ab typo prohibiting perf topsymbol annotation

[Arnaldo Carvalho de Melo]

Em Fri, Jan 22, 2010 at 07:39:39AM +0100, Mike Galbraith escreveu:
> 
> perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation
> 
> Signed-off-by: Mike Galbraith <efault@xxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> LKML-Reference: <new-submission>
> 
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 6f30fe1..af2e224 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1669,7 +1669,7 @@ do_kallsyms:
>  	free(kallsyms_allocated_filename);
>  
>  out_try_fixup:
> -	if (err > 0) {
> +	if (err <= 0) {
>  out_fixup:
>  		if (kallsyms_filename == NULL)
>  			dso__set_long_name(self, strdup("[kernel.kallsyms]"));

Strange, we need to fixup the map only if we found some symbol, so all
the routines there return the number of symbols found or -1 for errors,
investigating perf top symbol annotation now...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/