[PATCH -tip] perf report: Fix segmentation fault when running with'-g none'

From: Yong Wang
Date: Thu Jan 21 2010 - 20:53:53 EST


Segmentation fault occurs when running perf report with '-g none':

Starting program: /root/perf report -g none

Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? ()
(gdb) bt
#0 0x00000000 in ?? ()
#1 0x0808fbb9 in perf_session__insert_output_hist_entry (
min_callchain_hits=<value optimized out>, he=<value optimized out>,
root=<value optimized out>) at util/hist.c:169
#2 perf_session__output_resort (min_callchain_hits=<value optimized out>,
he=<value optimized out>, root=<value optimized out>) at util/hist.c:204
#3 0x080575e9 in __cmd_report () at builtin-report.c:228
#4 cmd_report () at builtin-report.c:385
#5 0x0804b528 in run_builtin (p=0x8146b88, argc=3, argv=0xbffff818)
at perf.c:263
#6 0x0804bd0b in handle_internal_command (argv=<value optimized out>,
argc=<value optimized out>) at perf.c:328
#7 run_argv (argv=<value optimized out>, argc=<value optimized out>)
at perf.c:372
#8 main (argv=<value optimized out>, argc=<value optimized out>) at perf.c:456

Reported-by: Austin Zhang <austin.zhang@xxxxxxxxx>
Signed-off-by: Yong Wang <yong.y.wang@xxxxxxxxx>

---
tools/perfbuiltin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 4c3d699..cfc655d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -279,7 +279,7 @@ parse_callchain_opt(const struct option *opt __used, const char *arg,

else if (!strncmp(tok, "none", strlen(arg))) {
callchain_param.mode = CHAIN_NONE;
- symbol_conf.use_callchain = true;
+ symbol_conf.use_callchain = false;

return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/