Re: [RFC PATCH] introduce sys_membarrier(): process-wide memorybarrier (v5)

From: Steven Rostedt
Date: Thu Jan 21 2010 - 11:32:28 EST


On Thu, 2010-01-21 at 11:22 -0500, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@xxxxxxxxxxx) wrote:

> > You may also need spin_lock_irqsave, et al. variants too.
>
> Yep, or we simply use the local_irq_save/restore separately. That could
> be a good idea given that only few specialized sites are affected.

If it gets used more often, then we need to consider RT. RT modifies
spin_lock_irqsave into a standard mutex that does not disable
interrupts. But if something does:

local_irq_save(flags);
spin_lock_mb(&lock);
[...]

Then it will break RT (if lock is to be converted).

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/