Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bittoo

[Linus Torvalds]

On Wed, 20 Jan 2010, Yinghai Lu wrote:
>
>  			printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
>  			       busnum, j,
>  			       (res->flags & IORESOURCE_IO)?"io port":"mmio",
> -			       res->start, res->end);
> +			       (u64)res->start, (u64)res->end);

When fixing these kinds of things, please just make it use '%pR' instead.

A simple

	printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res);

should do the right thing, printing the resource with nice human-readable 
flags. Including things like 64-bit/prefetching information for memory 
resources etc that the current manual resource printout doesn't do.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/